]> dgit.raspbian.org Git - gnome-shell.git/commit
appDisplay: Don't assume this._placeholder always exists
authorAlessandro Bono <alessandro.bono369@gmail.com>
Sun, 15 Jan 2023 15:34:38 +0000 (16:34 +0100)
committerMarge Bot <marge-bot@gnome.org>
Mon, 16 Jan 2023 20:24:26 +0000 (20:24 +0000)
commitec6ab60e62282e7ca59d0e8332bf946686499324
tree56219dacd4a475e058b3ed628c166b61a97b188f
parent24ae0854961eae054f09bae3f2dd371a5404a4e6
appDisplay: Don't assume this._placeholder always exists

Dropping a icon from the dash to the application grid will set this._placeholder
to null. However the AppIcon is still used to represent the application in the
application grid. If we click on it we emit a pressed event. Stop assuming
that this._placeholder is still valid in the callback, use the icon parameter
instead.

This fixes the following error:
```
Gjs-CRITICAL **: 18:22:39.003: JS ERROR: TypeError: this._placeholder is null
_ensurePlaceholder/<@resource:///org/gnome/shell/ui/appDisplay.js:1477:17
vfunc_button_press_event@resource:///org/gnome/shell/ui/appDisplay.js:3121:27
```

Fixes: 6fc93b78bc54763c0876951f2425fcfd96f61f00
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6317
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2606>
js/ui/appDisplay.js